Update the 'keymaps' documentation.#6369
Merged
vince-fugnitto merged 1 commit intomasterfrom Oct 15, 2019
Merged
Conversation
vince-fugnitto
added
keybindings
elaihau
reviewed
Oct 14, 2019
elaihau
reviewed
Oct 14, 2019
- update the documentation of the `@theia/keymaps` extension as part of the ongoing effort to improve documentation for the milestone 1.0.0 release. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/keymaps-docs
branch
from
0791b57 to
d147752
Compare
elaihau
approved these changes
Oct 15, 2019
Contributor
elaihau
left a comment
elaihau
left a comment
There was a problem hiding this comment.
looks good. Thank you Vincent !
Member
Author
|
Thank you for the review @elaihau ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Update the documentation of the
@theia/keymapsextension as part of the ongoing effort to improve documentation for the milestone 1.0.0 release.Note: (the following
tslintchecks were added to theerrors.tslint.jsonduring testing)How to test
Verify the documentation.
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com