[fs][plugin] fix #6661: map editor icon paths to external URIs#6664
Merged
svenefftinge merged 1 commit intomasterfrom Dec 1, 2019
Merged
[fs][plugin] fix #6661: map editor icon paths to external URIs#6664svenefftinge merged 1 commit intomasterfrom
svenefftinge merged 1 commit intomasterfrom
Conversation
VS Code extensions are using absolute paths to load editor icons. It does not work in remote environments. Instead we rewrite files URIs to external URIs to make it work. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
requested review from
azatsarynnyy,
svenefftinge and
vince-fugnitto
vince-fugnitto
approved these changes
Nov 29, 2019
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I verified the functionality (using the bookmarks plugin).
I first tested on master and I noticed that despite bookmarks actually being created, the icon was not displayed.
With your PR I noticed:
- the bookmark icons were correctly displayed locally 👍
- the bookmark icons were correctly displayed remotely (using Gitpod) 👍
svenefftinge
approved these changes
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
fix #6661: VS Code extensions are using absolute paths to load editor icons. It does not work in remote environments. Instead we rewrite files URIs to external URIs to make it work.
How to test
Review checklist
Reminder for reviewers