plugins: sort plugins in the plugins-view

[vince-fugnitto]

What it does

I generally use the plugins-view when debugging features to quickly determine which plugins are currently being consumed, however on master the list of plugins are unsorted making their discovery more difficult. I thought I'd do a quick-fix to correctly sort them for end-users.

The following commit adds a comparator method to the plugins-view so that plugins are sorted based on name, and publisher if required.

How to test

1. open the plugins-view and determine if plugins are successfully sorted by name (if the name is equal, verify that they are sorted by publisher name).

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[lmcbout]

Tested on Ubuntu 18.04
I have some plugins like: vscode-maven, vscode-java-debug, vscode-java-dependency, built-in java and redhat-java
I notice the builtin and redhat java are group together, but all the one starting with vscode-[...] are together at the end. Would it be nice to have all related one (JAVA) for example to get set in the same area. Since some plugins add the "vscode-" to their name and some just use a name (without vscode-)
Should we sort the name and remove the "vscode-" before the sorting ?
By the way, it looks nice this way too, but I would like them to be grouped together

[vince-fugnitto]

Should we sort the name and remove the "vscode-" before the sorting ?
By the way, it looks nice this way too, but I would like them to be grouped together.

I don't think we should hardcode values such as vscode- and remove it from the search.
We may have other java related extensions such as eclipse-java, and because of only removing vscode- they would not be grouped either way. I think the intuitive sort would just be alphabetical (since your suggestion would only work in a subset of cases).

[vince-fugnitto]

@lmcbout any objections to merging?

[lmcbout]

@vince-fugnitto It is already approved.
One thing before merging, can we just discuss at the today team meeting if there would be any other suggestions about grouping the plugins together! If no suggestions, then I am fine with merging :)

[vince-fugnitto]

One thing before merging, can we just discuss at the today team meeting if there would be any other suggestions about grouping the plugins together! If no suggestions, then I am fine with merging :)

As previously mentioned I don't think there is a way to generically apply additional sorting, but you can bring it up if its important to you.