Skip to content

[keybinding] Duplicate keybinding for opening the preferences widget and deleting file on navigator#8256

Merged
akosyakov merged 1 commit intoeclipse-theia:masterfrom
minyoungyang:keybinding
Aug 3, 2020
Merged

[keybinding] Duplicate keybinding for opening the preferences widget and deleting file on navigator#8256
akosyakov merged 1 commit intoeclipse-theia:masterfrom
minyoungyang:keybinding

Conversation

@minyoungyang
Copy link

Fixes #8202

What it does

  • Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

How to test

  • Open preference widget by pressing 'ctrl+,' on Windows
  • Delete files on navigator by pressing 'del' on Windows

Review checklist

Reminder for reviewers

Signed-off-by: Min-young Yang didalsdud@gmail.com

…and deleting file on navigator

Fixes: eclipse-theia#8202

Made keybindings not duplicated for opening the preferences widget and deleting file on navigator on MacOS

Signed-off-by: Min-young Yang <didalsdud@gmail.com>
@minyoungyang
Copy link
Author

@vince-fugnitto I create new pull request, because I had a problem with git. Review again please. Thank you.

@akosyakov akosyakov added the keybindings issues related to keybindings label Jul 29, 2020
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akosyakov akosyakov merged commit f803fc0 into eclipse-theia:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keybindings issues related to keybindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[preferences][keybinding] Duplicate keybinding for opening the preferences widget

4 participants