Merged
Conversation
Otherwise `FileService` fails to create the user directory. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
a1c9e28 to
1c2b803
Compare
vince-fugnitto
approved these changes
Aug 5, 2020
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I verified and the regression works successfully! 👍
I verified the following (removing the ~/.theia before each test):
- changing themes works correctly (the
settings.jsonis successfully created) - opening the
keymaps.jsonworks successfully (the file is created if it does not exist) - modifying the
keymaps.jsonthrough the UI works successfully again
akosyakov
commented
Aug 5, 2020
| } | ||
|
|
||
| /** | ||
| * Returns undefined if there is config URI at all for the given resource URI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
FileServicefails to create the user directory.How to test
Review checklist
Reminder for reviewers