Skip to content

cli: use decompress to decompress plugins#8315

Merged
paul-marechal merged 1 commit intomasterfrom
mp/decompress-plugins
Aug 11, 2020
Merged

cli: use decompress to decompress plugins#8315
paul-marechal merged 1 commit intomasterfrom
mp/decompress-plugins

Conversation

@paul-marechal
Copy link
Member

unzip-stream does not restore file permissions when decompressing
archives.

This commit replaces this library by decompress which restores file
permissions as stored in the archives.

Signed-off-by: Paul Maréchal paul.marechal@ericsson.com

What it does

Fixes #8306

How to test

Review checklist

Reminder for reviewers

`unzip-stream` does not restore file permissions when decompressing
archives.

This commit replaces this library by `decompress` which restores file
permissions as stored in the archives.

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
@paul-marechal paul-marechal added theia-cli issues related to the theia-cli dependencies issues that plan to update dependencies labels Aug 5, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work very well 👍 :

  • the decompressed plugins retain their file permissions
  • decompressing still works correctly (handling is still correct as well (errors + skipping))
  • less overall dependencies now that we reuse decompress

This is the result after attempting to download and decompress yangster:

gitpod /workspace/theia $ ls -lh plugins/ | grep "yangster"
drwxr-xr-x 3 gitpod gitpod 4.0K Aug  6 12:32 yangster

I'll give @marcdumais-work a chance to review as well.

@marcdumais-work
Copy link
Contributor

LGTM - I added yangster in package.json and ran yarn download:plugins and checked that the unzipped extension has its LS startup script with correct exec perms:

image

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marechal-p

@paul-marechal paul-marechal merged commit 1dfc6af into master Aug 11, 2020
@paul-marechal paul-marechal deleted the mp/decompress-plugins branch August 11, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies issues that plan to update dependencies theia-cli issues related to the theia-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode extension downloaded with @theia/cli script: files lose exec permission

3 participants