cli: use decompress to decompress plugins#8315
Merged
paul-marechal merged 1 commit intomasterfrom Aug 11, 2020
Merged
Conversation
`unzip-stream` does not restore file permissions when decompressing archives. This commit replaces this library by `decompress` which restores file permissions as stored in the archives. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
vince-fugnitto
approved these changes
Aug 6, 2020
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work very well 👍 :
- the decompressed plugins retain their file permissions
- decompressing still works correctly (handling is still correct as well (errors + skipping))
- less overall dependencies now that we reuse
decompress
This is the result after attempting to download and decompress yangster:
gitpod /workspace/theia $ ls -lh plugins/ | grep "yangster"
drwxr-xr-x 3 gitpod gitpod 4.0K Aug 6 12:32 yangster
I'll give @marcdumais-work a chance to review as well.
Contributor
marcdumais-work
approved these changes
Aug 6, 2020
Contributor
marcdumais-work
left a comment
There was a problem hiding this comment.
LGTM, thanks @marechal-p
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

unzip-streamdoes not restore file permissions when decompressingarchives.
This commit replaces this library by
decompresswhich restores filepermissions as stored in the archives.
Signed-off-by: Paul Maréchal paul.marechal@ericsson.com
What it does
Fixes #8306
How to test
theia-plugin-download).Review checklist
Reminder for reviewers