[explorer]: Badge count for dirty editors by Anasshahidd21 · Pull Request #8316 · eclipse-theia/theia

Anasshahidd21 · 2020-08-05T22:20:34Z

What it does

Fixes: #8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid muhammad.shahid@ericsson.com

How to test

Open an editor, make changes and don't save - make sure autosave is off
check the explorer icon if the badge count for dirty editor is increased
Undo the changes or save them, the count should decrease
Test with multiple dirty editors, using steps 1-3.

Review checklist

as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

vince-fugnitto

The changes work correctly:

the number of dirty editors is correctly displayed
the number of dirty editors are updated when the dirty state is changed, editors are closed
the display works with autoSave on with a delay

I understand that NavigatorTabBarDecorator had to implement FrontendApplicationContribution since ApplicationShell could not be injected and used.

packages/navigator/src/browser/navigator-frontend-module.ts

packages/navigator/src/browser/navigator-tab-bar-decorator.ts

akosyakov · 2020-08-10T09:18:31Z

packages/navigator/src/browser/navigator-tab-bar-decorator.ts

+
+    protected readonly emitter = new Emitter<void>();
+    private readonly toDispose = new DisposableCollection();
+    private readonly toDisposeOnDirtyChanged = new Map<Widget, Disposable>();


please don't hold a reference to a widget, but its id

Fixes: eclipse-theia#8296 Adds a badge count for dirty editors on the explorer tab icon. Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>

akosyakov

code-wise looks good to me

akosyakov · 2020-08-10T14:59:37Z

@vince-fugnitto could you test and merge please?

vince-fugnitto

I verified the latest changes and they work well, I'll merge.

kittaakos · 2020-11-04T14:41:25Z

@Anasshahidd21, how can I disable this feature without code modifications? Is there a preference for this?

Anasshahidd21 · 2020-11-04T15:15:24Z

@Anasshahidd21, how can I disable this feature without code modifications? Is there a preference for this?

@kittaakos, in the current state of main, it is only possible to disable this feature with code modifications and not by any preference.

kittaakos · 2020-11-04T15:25:42Z

Thank you! Here is the follow-up: #8709

vince-fugnitto reviewed Aug 5, 2020

View reviewed changes

packages/navigator/src/browser/navigator-frontend-module.ts Outdated Show resolved Hide resolved

vince-fugnitto added badge issues related to badge decorations navigator issues related to the navigator/explorer labels Aug 5, 2020

Anasshahidd21 force-pushed the dirtyEditors branch from ecdda15 to f23d916 Compare August 5, 2020 23:28