Skip to content

[badge]: Badge decoration for active debug sessions#8342

Merged
akosyakov merged 1 commit intoeclipse-theia:masterfrom
Anasshahidd21:debugSessionBadge
Aug 11, 2020
Merged

[badge]: Badge decoration for active debug sessions#8342
akosyakov merged 1 commit intoeclipse-theia:masterfrom
Anasshahidd21:debugSessionBadge

Conversation

@Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Aug 10, 2020

What it does

Fixes: #8303

Decorates the debug tab-bar with active debug sessions.

testt

How to test

# Test Cases Expected Result
1 Open a .spec file from Theia, run the config Run Mocha Test and check to see if the badge for debug reflects it Badge on Debug icon will show 1 active session
2 Check to see when the session is over, the badge decoration is updated The badge should decrement by 1
3 Stop an active session in middle, check to see if the badge decoration is updated The badge should decrement by 1

Review checklist

Reminder for reviewers

@Anasshahidd21 Anasshahidd21 force-pushed the debugSessionBadge branch 3 times, most recently from 7960661 to 8847075 Compare August 10, 2020 18:22
@vince-fugnitto vince-fugnitto added badge issues related to badge decorations debug issues that related to debug functionality labels Aug 10, 2020
Fixes: eclipse-theia#8303

Decorates the debug tab-bar with active debug sessions.

Co-authored-by: Kaiyue Pan <kaiyue.pan@ericsson.com>
Co-authored-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@akosyakov
Copy link
Member

I've rebased a commit and resolved a cycle generally in TabBarDecoratorService.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves well.

@akosyakov akosyakov merged commit 6feb470 into eclipse-theia:master Aug 11, 2020
@vince-fugnitto vince-fugnitto deleted the debugSessionBadge branch August 20, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

badge issues related to badge decorations debug issues that related to debug functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[debug] show running sessions count as a tab badge

3 participants