fix #8226: Add a settings menu on left sidebar bottom

[datou0412]

Signed-off-by: 二凢 dingyu.wdy@alibaba-inc.com

What it does

Fixes: #8226

Add a settings menu on left sidebar bottom.

How to test

1. Open a workspace.
2. Click the cog icon on the bottom of left sidebar, open the new Settings menu.
3. Click the menu item, 'Open Preferences' for instance, and it works.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

The idea is not to remove the file > settings menu item, but instead add a new way for end-users to access the menu items in the form of the sidepanel icon:

Example:

[datou0412]

The idea is not to remove the file > settings menu item, but instead add a new way for end-users to access the menu items in the form of the sidepanel icon:

Example:

keep both?

[vince-fugnitto]

keep both?

Yes, vscode does the same, the idea is not to force end-users to use one solution or the other but provide alternative ways for them to be able to access the menu. Removing the menus from File is a breaking behavior.

[datou0412]

The Mac version VSCode dose not have a Settings submenu of Files

[vince-fugnitto]

The Mac version VSCode dose not have a Settings submenu of Files

Then the solution should be operating-system specific like we have in other areas.
It is present on Linux (which is the screencasts I shared), and for Linux users they'd expect it.

Update: I believe it is present in vscode, just under a different menu, see: #6497

[vince-fugnitto]

@datou0412 thank you for updating the pull-request and restoring the top-level menu for settings 👍
The changes work very well, I verified that:

• each command works successfully
• the sidepanel entry for settings cannot be moved, and is always visible

I think we can think about adding more entries like command palette in future iterations as not to hold back the changes.

I'll also give others a chance to review as well 👍

[datou0412]

Need a re-review @akosyakov

[akosyakov]

wow that's very clean work, could you address comments if you are agree and we merge

[datou0412]

wow that's very clean work, could you address comments if you are agree and we merge

Of course, u r the boss :D