Conversation
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
vince-fugnitto
approved these changes
Aug 13, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I verified the same api-samples command on master and this pull-request does fix the ordering issue 👍
kittaakos
pushed a commit
to kittaakos/arduino-ide
that referenced
this pull request
Mar 22, 2023
- revert debug feature patching (eclipse-theia/theia#11984) - revert menu ordering hack (eclipse-theia/theia#8377) Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
Fixes the submenu ordering.
SubMenuOptions#orderis ignored when registering a submenu. See here.Before:
After:
How to test
Check the
Sample Menuand the corresponding API-sample code change.Review checklist
Reminder for reviewers