siw: respect 'files.exclude' preference#8433
Merged
vince-fugnitto merged 1 commit intomasterfrom Sep 14, 2020
Merged
Conversation
The commit updates the `search-in-workspace` search to respect the preference `files.exclude` when performing searches. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Co-authored-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
9 tasks
paul-marechal
approved these changes
Aug 28, 2020
Member
paul-marechal
left a comment
There was a problem hiding this comment.
LGTM, was able to ignore patterns!
There's a discrepancy with the way VS Code handles patterns (.json on VS Code works like *.json on Theia) but it is fine to keep this for later improvements.
Member
Author
Thank you for the review, I'll leave the pull-request open for a couple of days so others can get a chance to verify as well 👍 |
Anasshahidd21
approved these changes
Sep 14, 2020
Contributor
Anasshahidd21
left a comment
There was a problem hiding this comment.
The changes work well for me.
Tested on Gitpod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #7273
The following pull-request updates the
search-in-workspacesearch to respect thefiles.excludepreference (which describes glob patterns for exclusion). Currently, thefiles.excludepreference is not respected and the search yields incorrect results such as**/*.git.How to test
search-in-workspaceshould work correctly.files.excludeglobs.Examples:
**/*.git=true**/*.git=falseReview checklist
Reminder for reviewers