Introduces XSS sink detecting eslint rules#8481
Merged
marcdumais-work merged 1 commit intoeclipse-theia:masterfrom Sep 15, 2020
Merged
Introduces XSS sink detecting eslint rules#8481marcdumais-work merged 1 commit intoeclipse-theia:masterfrom
marcdumais-work merged 1 commit intoeclipse-theia:masterfrom
Conversation
LukeWood
force-pushed
the
master
branch
3 times, most recently
from
7cdc0f0 to
49020da
Compare
akosyakov
added
linting
Contributor
|
I am not an expert, but I was able to confirm that, if I re-introduce a XSS problem we previously fixed, it's picked-up by the new linting rule:
Other than the one pending comment, LGTM. @marechal-p Do you want to have a look? |
Contributor
|
BTW, the two dev-dependencies added though this PR are good, license-wise, according to the Foundation's approved license list. |
These eslint rules attempt to surface XSS sinks from eslint. This commit is a first pass on eclipse-theia#8398 Change-Id: I142bbba9785c4567dfbea1380f5a980560cf7413 Signed-off-by: LukeWood <lukewoodcs@gmail.com>
Contributor
Author
|
Should be good to go! fixed the 1 comment. |
paul-marechal
approved these changes
Sep 15, 2020
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
I was wondering if an error was better, but we can always upgrade later. LGTM.
Contributor
Author
IIRC we'd have a few errors in the build if it was error rather than warning ATM. |
Contributor
|
Thanks @LukeWood for this useful contribution! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These eslint rules attempt to surface XSS sinks from eslint.
This commit is a first pass on
#8398
Change-Id: I142bbba9785c4567dfbea1380f5a980560cf7413
What it does
How to test
Review checklist
Reminder for reviewers