Instantiate the returned FileSystem object for the frontend binding#8507
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Sep 24, 2020
Conversation
Fixes issue eclipse-theia#8497 Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
17297bc to
ed540ee
Compare
vince-fugnitto
approved these changes
Sep 24, 2020
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
Thank you for your first contribution @slhultgren! 👍
The changes work well for me when attempting to use the deprecated FileSystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8497
FileSystemclass, instead of the class.How to test
With this patch this following code will now work properly:
Will now work as expected instead of
this.fileSystem.existsbeingundefined.Review checklist
Reminder for reviewers
Signed-off-by: Samuel HULTGREN samuel.hultgren@st.com