Add missing DebugConsoleMode enum to vscode API#8513
Conversation
Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good to me (I haven't tested however).
I understand that the changes only add the enum but do we also want to make use of similarly to vscode for compatibility: startDebugging.
@vince-fugnitto maybe in a different PR? As far as I understand theia works with single repl and the task should be to support |
I'm fine with that, do you mind opening an issue so we at least track supporting the options? |
|
Opened separate issue: #8518 |
Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com
What it does
Add missing DebugConsoleMode enum to vscode API
How to test
One can try to access
vscode.DebugConsoleModefrom vscode extension code. Before this change it was undefined. Now it works.Review checklist
Reminder for reviewers