Skip to content

Add missing DebugConsoleMode enum to vscode API#8513

Merged
amiramw merged 1 commit intomasterfrom
debug-console
Sep 17, 2020
Merged

Add missing DebugConsoleMode enum to vscode API#8513
amiramw merged 1 commit intomasterfrom
debug-console

Conversation

@amiramw
Copy link
Member

@amiramw amiramw commented Sep 16, 2020

Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com

What it does

Add missing DebugConsoleMode enum to vscode API

How to test

One can try to access vscode.DebugConsoleMode from vscode extension code. Before this change it was undefined. Now it works.

Review checklist

Reminder for reviewers

Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me (I haven't tested however).
I understand that the changes only add the enum but do we also want to make use of similarly to vscode for compatibility: startDebugging.

@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality vscode issues related to VSCode compatibility labels Sep 17, 2020
@amiramw
Copy link
Member Author

amiramw commented Sep 17, 2020

The changes look good to me (I haven't tested however).
I understand that the changes only add the enum but do we also want to make use of similarly to vscode for compatibility: startDebugging.

@vince-fugnitto maybe in a different PR? As far as I understand theia works with single repl and the task should be to support Separate option of the enum.

@vince-fugnitto
Copy link
Member

The changes look good to me (I haven't tested however).
I understand that the changes only add the enum but do we also want to make use of similarly to vscode for compatibility: startDebugging.

@vince-fugnitto maybe in a different PR? As far as I understand theia works with single repl and the task should be to support Separate option of the enum.

I'm fine with that, do you mind opening an issue so we at least track supporting the options?

@amiramw
Copy link
Member Author

amiramw commented Sep 17, 2020

Opened separate issue: #8518

@amiramw amiramw merged commit 4739e26 into master Sep 17, 2020
@amiramw amiramw deleted the debug-console branch September 17, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debug issues that related to debug functionality vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants