Add environmentVariableCollection to PluginContext#8523
Merged
Conversation
azatsarynnyy
approved these changes
Oct 2, 2020
Member
azatsarynnyy
left a comment
There was a problem hiding this comment.
Works well. Thank you for providing the test plugin!
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Contributor
Author
|
@akosyakov @westbury Could you please take a look? |
Contributor
|
I propose to merge this PR this afternoon if there is no objection as it's already there since more than 3 weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What it does
Add
environmentVariableCollectiontoPluginContextto align it withExtensionContextfrom vscode.related CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22598
fixes #8405
How to test
F1 => Environment variable: Open terminal. This command opens a new terminal with predefined environment variables and changes them with the help of theenvironmentVariableCollectionplugin API:See :
echo $A $B $C, see:F1 => Environment variable: Clear collection, open a new terminal and typeecho $A $B $C: see an empty line.Review checklist
Reminder for reviewers