add isWeb Operating System context when clause#8530
Merged
azatsarynnyy merged 1 commit intoeclipse-theia:masterfrom Sep 28, 2020
Merged
add isWeb Operating System context when clause#8530azatsarynnyy merged 1 commit intoeclipse-theia:masterfrom
azatsarynnyy merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: Mohit Suman <mohit.skn@gmail.com>
azatsarynnyy
added
plug-in system
Member
azatsarynnyy
left a comment
azatsarynnyy
left a comment
There was a problem hiding this comment.
Thanks @mohitsuman for your contribution!
Please, provide the steps on how this patch can be validated, in How to test section.
It helps the reviewers to check it as well.
paul-marechal
approved these changes
Sep 28, 2020
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
LGTM.
Tested binding a shortcut using this new context, and I was able to only enable it for the web frontend.
Member
|
Thanks @marechal-p for testing the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohit Suman mohit.skn@gmail.com
What it does
It adds
isWebOperating System context to the theia API. Fixes #8529How to test
Adds supports same as in vscode API for when clause.
If it is running in electron mode, isWeb would return false. And if running on Che/CRW, it would return true.
Review checklist
Reminder for reviewers