monaco: command Save All now formats all open editors#8551
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Sep 28, 2020
Merged
Conversation
Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
Save All now formats all opening editorsSave All now formats all open editors
1 task
vince-fugnitto
approved these changes
Sep 28, 2020
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work very well with the example provided in the comment.
Now when we perform the save all we format all open documents and not only the currently active one (similarly to vscode).
paul-marechal
approved these changes
Sep 28, 2020
Member
paul-marechal
left a comment
There was a problem hiding this comment.
LGTM, this way ensures the command is ran directly on the editor and avoids the indirection through this commandService property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8547
Save Allnow formats all opening editors.executeCommandfromcommandService, callingrunActionto manually format each editor.runActionis being used similar to Manually execute "Format Code" action microsoft/monaco-editor#32 (comment)How to test
formatOnSaveis onSave Allfrom the command palette or from a shortcutReview checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com