plugin: support 'deprecated' strikethrough#8553
Merged
vince-fugnitto merged 1 commit intomasterfrom Oct 5, 2020
Merged
Conversation
vince-fugnitto
added
editor
Contributor
|
I tested and confirmed the PR works exactly as expected 👍 |
DucNgn
approved these changes
Sep 24, 2020
amiramw
reviewed
Oct 1, 2020
vince-fugnitto
force-pushed
the
vf/GH-8552
branch
from
205ad40 to
1b1af4b
Compare
The following pull-request adds support for the following: - support for `tags` strikethrough for deprecated completion items. - support for the deprecated `deprecated` flag for completion items. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-8552
branch
from
1b1af4b to
65e157b
Compare
amiramw
approved these changes
Oct 1, 2020
Member
amiramw
left a comment
amiramw
left a comment
There was a problem hiding this comment.
Code LGTM. Also tested and the fix work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8552
The following pull-request adds support for the following:
tagsstrikethrough for deprecated completion items.deprecatedflag for completion items.Both the
taganddeprecatedproperties should be visibly different (strikethrough) to indicate deprecated items.How to test
textfileReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com