Merged
Conversation
vince-fugnitto
added
quality
Member
Author
|
cc @benoitf I hope this change does not impact Che too much, I thought I'd create a pull-request solely for the |
JPinkney
approved these changes
Sep 24, 2020
Contributor
|
thanks @vince-fugnitto |
benoitf
approved these changes
Sep 25, 2020
Contributor
|
I've restarted macos travis job |
The following commit fixes misc typos found in the `@theia/plugin-metrics` extension, and includes the following breaking change: - renamed `AnalyticsFromRequests.succesfulResponses` to `AnalyticsFromRequests.successfulResponses`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/plugin-metrics-typos
branch
from
e13ba2b to
100066f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The following commit fixes misc typos found in the
@theia/plugin-metricsextension,and includes the following breaking change:
AnalyticsFromRequests.succesfulResponsestoAnalyticsFromRequests.successfulResponses.How to test
The CI should be green (build and test of
@theia/plugin-metrics).Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com