Added documentation for Label Provider and Contribution#8569
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Oct 14, 2020
Merged
Added documentation for Label Provider and Contribution#8569vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
changed the title
JonasHelming
force-pushed
the
labelprovider
branch
2 times, most recently
from
bbd37af to
85c769d
Compare
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
While addressing the following comments, can you also update the commit message, at the moment there are typos as well:
Added docu for Label Provider
JonasHelming
force-pushed
the
labelprovider
branch
from
85c769d to
a535d35
Compare
fixes eclipse-theia#8568 Contributed on behalf of STMicroelectronics Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming
force-pushed
the
labelprovider
branch
from
a535d35 to
cc05e15
Compare
vince-fugnitto
approved these changes
Oct 8, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The documentation updates look good to me @JonasHelming, thank you for the contribution!
Member
|
@JonasHelming are there other edits you expect to include, or need help with a merge? |
Contributor
Author
|
merge would be fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8568
Contributed on behalf of STMicroelectronics
Signed-off-by: Jonas Helming jhelming@eclipsesource.com
What it does
Adds documentation to LabelProvider and LabelProviderContribution
How to test
Documentation changes only
Review checklist
Reminder for reviewers