[vscode] semantic highlighting support

[akosyakov]

What it does

• fix Activating extension rust-analyzer failed: vscode.languages.registerDocumentSemanticTokensProvider is not a function. #7608: porting VS Code support of semantic highlighting
• CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677 (waiting for check-in approval)

How to test

• start theia
• open application-shell.ts
• observe how imports are colored before ts smartness is ready and after
  • you can see whether ts smartness initialization progress in the status bar
• open preferences side by side with the editor, find semantic highligting toggle, use it and see how highlighting is changing in the editor

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

It's turned out that it is required Monaco 0.21.0. Monaco 0.20.0 is not complete. I've patched the theming standalone service for now with fixed from 0.21.0. We should remove the patch after next migration.

[JanKoehnlein]

LGTM.

[kittaakos]

@akosyakov,

• Do you know if the current changeset will be (fully) compatible with the LSP-based semantic-highlighting out of the box once it's released? Or will that be available only with monaco 0.22.x or 0.23.x?
• Can you please recommend another VS Code extension I could use to try out the new feature of this PR?
• It seems the formatter does not work correctly on your side. Please fix the indentations.

Thank you!

[dunnry]

The F# Ionide Extension uses this feature if you want to test it. @kittaakos

[JanKoehnlein]

So does the Java extension

…

Am 07.10.2020 um 23:03 schrieb dunnry ***@***.***>:  The F# Ionide Extension uses this feature if you want to test it. @kittaakos — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

[vince-fugnitto]

I believe the CQ has now been successfully approved 👍

[akosyakov]

Could someone help with rebasing and merging it?

[azatsarynnyy]

I just wonder are we allowed to use the code in an Eclipse repo if the related CQ is still in awaiting_analysis state?
Does that mean it's approved?

[akosyakov]

We only need checkin tag as far as I know. cc @marcdumais-work

[vince-fugnitto]

I just wonder are we allowed to use the code in an Eclipse repo if the related CQ is still in awaiting_analysis state?
Does that mean it's approved?

@azatsarynnyy I know in the past we proceeded to merge pull-requests when they granted permission, namely the following:

We have completed a high level triage of the attachment and you may now check the content into your project’s source code repository.

I believe at this point they will continue to verify the content (awaiting_analysis), and if an issue arises they will notify us.

[azatsarynnyy]

Thanks @vince-fugnitto for the explanation!

[vince-fugnitto]

@akosyakov do we want to merge for today's release?

[akosyakov]

@vince-fugnitto merge when it suites you

[vince-fugnitto]

I reviewed the changes and they work well 👍
I'll merge and if there are issues we have the month to resolve any of them.