vsx-registry: fix the search query based on the search parameters#8607
Merged
vince-fugnitto merged 1 commit intomasterfrom Oct 8, 2020
Merged
vsx-registry: fix the search query based on the search parameters#8607vince-fugnitto merged 1 commit intomasterfrom
vince-fugnitto merged 1 commit intomasterfrom
Conversation
vince-fugnitto
added
bug
The following commit fixes the `open-vsx` search query: - fixes the `search` query when multiple search parameters are used. - adds a test to verify the search query. - adds support for additional search parameters (`sortOrder`, `sortBy`, and `includeAllVersions`). Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/vsx-query
branch
from
cb0ef39 to
9d2d1ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The following pull-request fixes the open-vsx search query which was previously incorrectly built when providing multiple search parameters.
sortBy,sortOrder, andincludeAllVersions).How to test
extensionsviewReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com