Merged
Conversation
vince-fugnitto
added
quality
benoitf
approved these changes
Oct 14, 2020
paul-marechal
approved these changes
Oct 14, 2020
1 task
vince-fugnitto
force-pushed
the
vf/eslint-no-tabs
branch
2 times, most recently
from
efc7d4c to
3975e1f
Compare
paul-marechal
approved these changes
Oct 20, 2020
The following commit adds the `no-tabs` eslint rule to enforce that `spaces` should always be used as according to the project rules, and `editorconfig` properties. The rule will now display errors for use of `tabs` over `spaces`, and it ensures that new pull-requests do not break this pattern, and cause unecessary changes when formatting the documents or performing a `save`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The following commit updates the `ignorePatterns` to include `*.d.ts` files maintained by the project and exclude `lib` folders. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/eslint-no-tabs
branch
from
3975e1f to
c4c6735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8632
The following pull-request adds the no-tabs eslint rule in order to enforce
spacesversustabsthroughout the project and fixes any occurrences.We currently define
spacesas the proper indentation:theia/.vscode/settings.json
Line 38 in 40b3800
theia/.editorconfig
Line 6 in 40b3800
How to test
tabsversusspacesshould result in error markers, and fail the build.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com