Add documentation for widget manager & open handler#8644
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Oct 23, 2020
Merged
Add documentation for widget manager & open handler#8644vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The documentation updates look very good with a few minor comments.
In a previous documentation pull-request I brought up a question regarding the use of {@link}
which unfortunately does not work properly: #8637 (comment).
vince-fugnitto
added
core
Contributor
Author
|
Thanks for the fast review. I addressed the mentioned issues and only used @link for the first occurrence in the documentation block. (as suggested in #8637 (comment)) |
vince-fugnitto
approved these changes
Oct 22, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The content looks very good, I have a very minor comment only.
FIxes eclipse-theia#8643 - Document 'WidgetManager' and related interfaces - Document 'WidgetOpenHandler' and related interfaces Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com> Contributed on behalf of STMicroelectronics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes #8643
Signed-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
Contributed on behalf of STMicroelectronics
What it does
Adds/refines documentation for
WidgetManagerandWidgetOpenHandlerHow to test
Documentation only
Review checklist
Reminder for reviewers