Add API doc for 'BackendApplicationContribution'#8686
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Nov 4, 2020
Merged
Conversation
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
Few comments, LGTM otherwise :)
sdirix
force-pushed
the
backendcontribution-documentation
branch
from
069e60a to
0a4c5ae
Compare
Member
Author
|
@marechal-p Thanks for the quick review 👍. I adressed your comments. Please let me know whether you would like to see further changes :) |
Signed-off-by: Stefan Dirix <sdirix@eclipsesource.com> Contributed on behalf of STMicroelectronics
sdirix
force-pushed
the
backendcontribution-documentation
branch
from
0a4c5ae to
4936090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8685
Signed-off-by: Stefan Dirix sdirix@eclipsesource.com
Contributed on behalf of STMicroelectronics
What it does
Add API doc for
BackendApplicationContributionHow to test
Check whether API Doc is correct and run
yarn run lintto check for formatting errors.Review checklist
Reminder for reviewers