Documentation for TreeDecorator & TreeDecoratorService#8698
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Nov 5, 2020
Merged
Documentation for TreeDecorator & TreeDecoratorService#8698vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
TreeDecorator & TreeDecoratorService#8698vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The overall content looks good 👍
vince-fugnitto
added
core
tortmayr
force-pushed
the
tree
branch
2 times, most recently
from
dacdcf2 to
3edc6e4
Compare
Contributor
Author
|
Thanks for the fast review. I applied your feedback suggestions. |
vince-fugnitto
approved these changes
Nov 4, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good 👍
Please be sure to squash and include a proper sign-off (currently failing the eca check) so we can merge.
Fixes eclipse-theia#8696 - Refine documentation for `TreeDecorator` - Refine documentation for `TreeDecoratorService` Signed-off-by: Tobias Ortmayr <tortmayr@eclipsesource.com> Contributed on behalf of STMicroelectronics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8696
TreeDecoratorTreeDecoratorServiceSigned-off-by: Tobias Ortmayr tortmayr@eclipsesource.com
Contributed on behalf of STMicroelectronics
What it does
Add/refines documentation for TreeDecorator.
How to test
Documentation changes only
Review checklist
Reminder for reviewers