Render initial preview for empty documents#8729
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Nov 13, 2020
Merged
Render initial preview for empty documents#8729vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
The preview-widget checks whether the content of the underlying text document changed before rerendering its content. In case of empty documents this check prevented the initial rendering of the preview. This is now fixed by distinguishing between empty and non-existing content. Signed-off-by: Stefan Dirix <sdirix@eclipsesource.com> Contributed on behalf of STMicroelectronics
vince-fugnitto
approved these changes
Nov 10, 2020
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work well for me with the provided example.
When documents are empty, the preview is now correctly rendered.
Member
|
I'll merge tomorrow if there are no objections. |
Member
Author
|
@vince-fugnitto Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves preview-widget to also render previews for empty documents.
Fixes #8728
Signed-off-by: Stefan Dirix sdirix@eclipsesource.com
Contributed on behalf of STMicroelectronics
What it does
The preview-widget checks whether the content of the underlying text document changed before rerendering its content. In case of empty documents this check prevented the initial rendering of the preview. This is now fixed by distinguishing between empty and non-existing content.
How to test
PreviewHandlerwhich renders content for empty documentsYou can use this
PreviewHandlerfor testing:Review checklist
Reminder for reviewers