Remove dependencies pulled in when writing to output channels#8733
Merged
Remove dependencies pulled in when writing to output channels#8733
Conversation
Signed-off-by: Nigel Westbury <nigelipse@miegel.org>
vince-fugnitto
added
extensibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The changes to add scroll lock to the output view added a large number of dependencies to OutputChannelManager. While the scroll locking is a great improvement and much appreciated, the extra dependencies make it not possible for extenders to send logging output to the Output view. An attempt to inject OutputChannelManager into MessageClient causes a circular dependency. OutputChannelManager depends on QuickPickService which depends on QuickOpenService (bound to MonacoQuickOpenService), which depends on KeyboardLayoutProvider (implemented by BrowserKeyboardLayoutProvider) which depends on ILogger.
The dependencies are caused by the command registrations. The dependencies can be removed by moving the command registrations to the same place where other output channel commands are registered. This also removes the command registration from 'common'.
How to test
Ensure that no behavior is changed. All commands are accessible exactly as before.
Review checklist
Reminder for reviewers