[Fix] WorkspaceFrontendContribution is not binded to FrontendApplication#8734
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Nov 11, 2020
Merged
[Fix] WorkspaceFrontendContribution is not binded to FrontendApplication#8734vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
added
bug
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@DoroNahari the changes work well for me, thank you for taking care of it 👍
Please be sure to update the pull-request to include a sign-of (currently failing) so we can merge.
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
Contributor
Author
Done. you can merge now. Thank you @vince-fugnitto |
vince-fugnitto
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Bind WorkspaceFrontendContribution to FrontendApplication.
Today they are not binded and this causes the
workspaceFrontendContribution.configure()to not being called.This make the statusBar color blue (instead of purple) even if workspace is not opened.
How to test
Open Theia in browser.
Open browser dev tools.
In the dev tools, open
workspace-frontend-contribution.tsfile and put breakpoint inside theconfiguremethod.Before:
configure()isn't being called. the debugger doesn't stop insideconfigure()After:
configure()is called. the debugger stop insideconfigure()Another way:
Open theia without opened workspace or click File -> Close Workspace
Before:
The status bar is blue instead of purple.
After:
The status bar is purple.
Review checklist
Reminder for reviewers