Merged
Conversation
vince-fugnitto
added
ci
vince-fugnitto
force-pushed
the
vf/ci-fix
branch
from
5591a5c to
877a479
Compare
The following commit fixes an issue with the `saveable.spec.js` api test, where due to a quick `ADDED/DELETE` event, NSFW was not properly notified of the event, causing the test to fail when attempting to verify its assertions, namely when verifying if the title has been updated. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/ci-fix
branch
from
877a479 to
a17553b
Compare
Member
Author
|
Amended PR to re-test passing CI. |
paul-marechal
approved these changes
Nov 10, 2020
Member
Author
|
Hopefully this pull-request helps stabilize CI a bit. There are still some sporadic failures in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8681
The following pull-request fixes an issue with the
saveable.spec.jsapi test which failed due to anADDED/DELETEDevent which NSFW did not report properly (since it was performed in quick succession - related #2566).The main issue is the following use-case:
delete file for savedtest deletes a filebeforeEachcreates a file anddelete and add again file for dirtydeletes the file again in quick successionnsfwdoes not emit thedeletedevent properly, resulting in the widget being disposedwidget.title.changed.disconnect(listener);making theawait waitForDidChangeTitle.promise;hang.How to test
Verify that the
saveableapi-tests successfully pass on CI.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com