[@theia/console] Remove workaround that is no longer necessary#8741
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Nov 12, 2020
RDIL:master
Merged
[@theia/console] Remove workaround that is no longer necessary#8741paul-marechal merged 1 commit intoeclipse-theia:masterfrom RDIL:master
paul-marechal merged 1 commit intoeclipse-theia:masterfrom
RDIL:master
Conversation
RDIL
commented
Nov 11, 2020
vince-fugnitto
added
dependencies
Signed-off-by: Reece Dunham <me@rdil.rocks>
paul-marechal
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reece Dunham me@rdil.rocks
What it does
My PR in Anser (IonicaBizau/anser#60) landed, meaning that the misleading TypeScript types no longer exist, so we can just use the proper way of importing Anser.
How to test
I've verified that the Theia console still works.
Review checklist
Reminder for reviewers