Update eslint to the latest version

[benoitf]

What it does

Update eslint to the latest version
Need to rename no-shadow to @typescript-eslint/no-shadow as specified there
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md

How to test

build should be working as I changed only comments in source code

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Change-Id: Ib864501e48772b224b4999718f4f8dfbeb8964d6
Signed-off-by: Florent Benoit fbenoit@redhat.com

[vince-fugnitto]

I verified the following 👍

• I confirmed that the new dependencies are license compatible following the guidelines.
• I confirmed that the new rule works correctly, and pre-existing rules also work with the new eslint update.

[benoitf]

@vince-fugnitto should I wait somehow to have travis-ci back ?

[vince-fugnitto]

@vince-fugnitto should I wait somehow to have travis-ci back ?

@benoitf I build the pull-request locally, and ran the tests (at least on Linux).
I'm not sure how long it will take to have Travis back (since we ran out of credits), it is likely we will need to replace it with GitHub actions. However, if you'd like to be safe we can bring it up in the dev meeting if you think we should hold off pull-requests till the release.

[benoitf]

so we've successful builds on linux (your case) and macos (my case) so I would say we're fine to merge.

[vince-fugnitto]

so we've successful builds on linux (your case) and macos (my case) so I would say we're fine to merge.

I believe so, I can have a colleague test on windows if you'd like?

[benoitf]

@vince-fugnitto that would be perfect

[vince-fugnitto]

@vince-fugnitto that would be perfect

@dukengn do you mind confirming the changes work correctly on windows? (since there is no CI at the moment)

[DucNgn]

I have tested on Windows and confirmed that the new rules work great and the existing rules are also working well with the update 👍