[siw] Add search.searchOnType preference#8773
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Dec 7, 2020
Merged
[siw] Add search.searchOnType preference#8773vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
search.searchOnType preference#8773vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
added
preferences
DucNgn
force-pushed
the
dn/searchDebounce
branch
2 times, most recently
from
056959b to
36a1947
Compare
DucNgn
force-pushed
the
dn/searchDebounce
branch
2 times, most recently
from
47c914b to
e33e7fc
Compare
+ Add `search.searchOnType` preference to control whether or not to search as user updating search term. + Add `search.searchOnTypeDebouncePeriod` preference to control the timeout in milliseconds between a character being typed and the search starting. Has no effect when `search.searchOnType` is disabled. Co-authored-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
DucNgn
force-pushed
the
dn/searchDebounce
branch
from
e33e7fc to
1b8692f
Compare
vince-fugnitto
approved these changes
Dec 4, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work very well, thank you @dukengn ! 👍
I'll merge early next week if there are no objections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8774.
search.searchOnTypepreference to control whether or not to search as a user updating search term.search.searchOnTypeDebouncePeriodpreference to control the timeout in milliseconds between a character being typed and the search starts. Has no effect whensearch.searchOnTypeis disabled.How to test
search.searchOnType:search.searchOnTypesearch.searchOnType, then the search only starts when user pressENTERin the search input boxsearch.searchOntypeDebouncePeriod:searchOnTypeis enabledReview checklist
Reminder for reviewers
Co-authored-by: vince-fugnitto vincent.fugnitto@ericsson.com
Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com