Conversation
Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
vince-fugnitto
added
dependencies
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the updated dependency version is license compatible 👍 :
@amiramw in the future, you can also perform this check based on the "documentation for new or updated dependencies", and reflect it in the pull-request description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com
What it does
Upgrade highlight.js to 10.4.1 as it contain security fix. See https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md#version-1041-tentative
How to test
Create md file with code block highlight that has a language in it and make sure the preview pane show syntax highlighs as before.
See also https://community.theia-ide.org/t/preview-highlight-help/1341/2
Review checklist
Reminder for reviewers