Fix horizontal scrollbar not to disappear#8898
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Jan 13, 2021
Merged
Fix horizontal scrollbar not to disappear#8898colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
Conversation
Contributor
Author
|
I found |
Signed-off-by: Ken Aoki <ken3574.25@gmail.com>
Contributor
Author
|
I changed the way to fix. |
vince-fugnitto
added
bug
DucNgn
approved these changes
Jan 4, 2021
Contributor
There was a problem hiding this comment.
LGTM 👍
I confirm that:
- with many opening files on the tab bar, the scrollbar doesn't disappear when either scroll to right or to left.
- resize the application window, the scrollbar still works as expected.
- resize editor view (horizontally and vertically), the scrollbar still appears when scrolling to both ends.
OS: macOS
colin-grant-work
approved these changes
Jan 8, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
This looks good to me. This feature of perfect scrollbar causes a lot of pain - it's easy to forget to set the position!
Contributor
Author
|
@dukengn @colin-grant-work Thank you for the review. Is there anything I need to do for this PR to be merged? |
Contributor
|
@kena0ki, good to go, and now done. |
Contributor
Author
|
@colin-grant-work Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Aoki ken3574.25@gmail.com
What it does
Fixes #8886.
The moduleperfect-scrollbarunnecessarily moves the horizontal scrollbar to right. This PR set position attribute for the horizontal scrollbar tostaticso that it can't be moved.This PR adds
position: relativeto style for the scrollbar container as per perfect-scrollbar README.How to test
Review checklist
Reminder for reviewers