make extension deploy command extensible#8919
Merged
amiramw merged 1 commit intoeclipse-theia:masterfrom Jan 14, 2021
Merged
Conversation
packages/plugin-ext/src/main/browser/plugin-ext-deploy-command.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/plugin-ext-deploy-command.ts
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
@odeliat thank you for updating the pull-request, I have a minor comment regarding the changelog entry.
When ready with the updates, please be sure to squash your commits (into a single commit), and include a proper sign-off before it can be accepted.
…em` in order to make extension deploy command extensible Signed-off-by: odelia <odelia.zehavi@sap.com>
odeliat
force-pushed
the
extesible-deploy-cmd
branch
from
0333612 to
d3f2817
Compare
amiramw
approved these changes
Jan 12, 2021
Member
amiramw
left a comment
amiramw
left a comment
There was a problem hiding this comment.
Code LGTM and tested deploy by id command to make sure there are no regressions.
vince-fugnitto
added
extensibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: odelia odelia.zehavi@sap.com
What it does
Make the extension deploy from command pallet extensible
How to test
> Plugin: Deploy Plugin by Idvscode:extension/hollowtree.vue-snippetsIn this branch you can see the ability in work:
https://github.com/odeliat/theia/tree/extensible-deploy-cmd-test
Review checklist
Reminder for reviewers