Conversation
The issue is a regression introduced in #8783 Calculation of parent chain (for id calculation) calls getChildren which dispose nodes. This means that reveal for a node that is already revealed dispose the node and so the frontend has an id that doesn't exist in the backend anymore so tree item command is not found. The fix is to check the cache before calling getChildren and making sure that the technical root is also in the cache. Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
Member
Author
|
@kittaakos can you please review this fix? |
kittaakos
approved these changes
Jan 22, 2021
Contributor
kittaakos
left a comment
kittaakos
left a comment
There was a problem hiding this comment.
I have verified the steps, it worked. 👍 Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com
What it does
The issue is a regression introduced in #8783
Calculation of parent chain (for id calculation) calls getChildren which dispose nodes.
This means that reveal for a node that is already revealed dispose the node and so the frontend has an id that doesn't exist in the backend anymore so tree item command is not found.
The fix is to check the cache before calling getChildren and making sure that the technical root is also in the cache.
How to test
cd project1 && npm iReview checklist
Reminder for reviewers