Specify order of 'Select for Compare' and 'Compare with Selected'#8926
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Jan 7, 2021
Merged
Specify order of 'Select for Compare' and 'Compare with Selected'#8926paul-marechal merged 1 commit intoeclipse-theia:masterfrom
paul-marechal merged 1 commit intoeclipse-theia:masterfrom
Conversation
… To more clearly specify the order in which navigator menu items are to be displayed, 'Select for Compare' and 'Compare with Selected' were assigned order 'za' and 'zb', respectively. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
vince-fugnitto
approved these changes
Jan 7, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@seantan22 the changes look good to me, thank you for your first pull-request 👍
I confirmed that the order is consistent with master but is now more explicit.
vince-fugnitto
added
menus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both 'Select for Compare' and 'Compare with Selected' had order: 'z'. To more clearly specify the order in which navigator menu items are to be displayed, 'Select for Compare' and 'Compare with Selected' were assigned order 'za' and 'zb', respectively.
Signed-off-by: seantan22 sean.a.tan@ericsson.com
What it does
Both 'Select for Compare' and 'Compare with Selected' had
order: 'z'. To more clearly specify the order in which navigator menu items are to be displayed, 'Select for Compare' and 'Compare with Selected' were assigned order 'za' and 'zb', respectively.How to test
When comparing two files in the navigator, observe that when the second file for comparison is chosen, the option 'Compare with Selected' appears below the option 'Select for Compare'"
Review checklist
Reminder for reviewers