Fix running a task when 'cwd' is not provided#8949
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Jan 18, 2021
Merged
Fix running a task when 'cwd' is not provided#8949paul-marechal merged 1 commit intoeclipse-theia:masterfrom
paul-marechal merged 1 commit intoeclipse-theia:masterfrom
Conversation
The issue was triggered by launching a debug session which includes a "preLaunchTask" referencing a build task. The issue happened even if the "cwd" option was present in the tasks.json file The check triggering the error was removed as the 'cwd' options should not be mandatory see 'options' under [3] as well as comment [2]. [1] eclipse-theia#8930 [2] eclipse-theia#5024 (comment) [3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
vince-fugnitto
added
bug
vince-fugnitto
approved these changes
Jan 14, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
Thank you for investigating the issue, and providing a solution 👍 I confirmed that the changes work successfully when using a preLaunchTask and postDebugTask.
I believe it is the proper fix since:
cwdhas a default value (${workspaceFolder}), and is not mandatory in the schema definitions of vscode.- it seems to be a leftover as you mentioned clearly in the description.
vince-fugnitto
requested review from
RomanNikitenko,
paul-marechal and
tsmaeder
RomanNikitenko
approved these changes
Jan 18, 2021
Contributor
RomanNikitenko
left a comment
RomanNikitenko
left a comment
There was a problem hiding this comment.
The changes look reasonable to me.
Tested using steps to reproduce section of #8930 - the PR fixes the issue for me.
thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a check that seems to be a change leftover from change [2]
The issue was triggered by launching a debug session which includes a
"preLaunchTask" referencing a build task.
The issue happened even if the "cwd" option was present in the tasks.json file
The check triggering the error was removed as the 'cwd' options should not be
mandatory see options under [3].
[1] #8930
[2] #5024 (comment)
[3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks
Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com
What it does
The check triggering the error was removed as the 'cwd' options should not be
mandatory see options under [3].
[1] #8930
[2] #5024 (comment)
[3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks
How to test
The steps to reproduce the issue and test the fix manually are under issue:
#8930
In addition the @theia/tasks and @theia/core tests were executed successfully
Review checklist
Reminder for reviewers