Skip to content

Implement vscode navigateBack, navigateForward, and navigateToLastEditLocation commands#8958

Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
danieltomasku:feature/vscode-back-forward-commands
Jan 20, 2021
Merged

Implement vscode navigateBack, navigateForward, and navigateToLastEditLocation commands#8958
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
danieltomasku:feature/vscode-back-forward-commands

Conversation

@danieltomasku
Copy link
Contributor

Signed-off-by: Daniel Ku daniel.ku@ericsson.com

What it does

This PR maps the VS Code commands navigateBack, navigateForward, and navigateToLastEditLocation to their respective Theia commands. Closes #8956

How to test

  1. Install the Back & Forth extension
  2. Open some files and navigate around a codebase
  3. Use the back and forward buttons in the editor tabbar
  4. Confirm that the back and forward buttons are working as expected

theia-back-forth

Review checklist

Reminder for reviewers

…ditLocation commands

Signed-off-by: Daniel Ku <daniel.ku@ericsson.com>
@colin-grant-work
Copy link
Contributor

With the caveat of #8955 - opening any file, no matter how it's done, whether through code navigation or workspace search, always adds the first line to the navigation stack - this works for me, and appears to be consistent with how other VSCode commands are mapped to Theia commands. 👍

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jan 18, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

@vince-fugnitto
Copy link
Member

@danieltomasku do you need help with merging? :)

@colin-grant-work colin-grant-work merged commit 885c679 into eclipse-theia:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS Code Back and Forward commands not mapped to Theia commands

3 participants