8536-compatibility-third-party-themes#8964
Merged
amiramw merged 1 commit intoeclipse-theia:masterfrom Feb 3, 2021
Merged
Conversation
Signed-off-by: Dan Arad <dan.arad@sap.com>
Contributor
Author
1 similar comment
Contributor
Author
vince-fugnitto
added
bug
vince-fugnitto
approved these changes
Feb 3, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@danarad05 thank you for the contribution, I confirmed that the pull-request fixes the issue regarding the monaco theme not being properly set.
- verified using
atom one dark: https://open-vsx.org/extension/akamud/vscode-theme-onedark - verified all other bundled themes that no regressions are present
Contributor
Author
Thanks @vince-fugnitto. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Arad dan.arad@sap.com
What it does
Fixes #8536
#8536 issue is caused because "Atom One Dark" (as example) had settings for foreground color inherit and white among others. white would be replaced by
normalizeColorfunction with undefined, while inherit would eventually generate exception in getId function because inheri didn't conform to color regexp.How to test
See explanation at #8536
Review checklist
Reminder for reviewers