Highlight Toggled State of Toolbar Items#8968
Merged
vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom Jan 28, 2021
Merged
Highlight Toggled State of Toolbar Items#8968vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
added
enhancement
colin-grant-work
requested changes
Jan 19, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Works well for me, and the code looks good for the most part, with a couple of minor issues.
examples/api-samples/src/browser/view/sample-unclosable-view-contribution.ts
Outdated
Show resolved
Hide resolved
What It Does Adds a sample toolbar item (add/plus icon) to the sample view toolbar that can be toggled. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
force-pushed
the
toggle-toolbar-item
branch
from
0388507 to
5088583
Compare
Fixes [eclipse-theia#8312](eclipse-theia#8312) What It Does - Renders toolbar items with a highlighted background if in a toggled state. How To Test 1. Go to View -> Sample Unclosable View 2. Click on the toolbar item (add/plus icon) to toggle and observe that a highlighted background appears behind the toolbar icon. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
force-pushed
the
toggle-toolbar-item
branch
from
5088583 to
f3482c5
Compare
Contributor
|
The code looks good to me. @vince-fugnitto or @marechal-p, would you be willing to give it a once over to make sure it isn't doing something in the example views that shouldn't be done? |
colin-grant-work
approved these changes
Jan 21, 2021
vince-fugnitto
approved these changes
Jan 27, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good to me 👍
I can merge the updates tomorrow if there are no objections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8312
How to test
observe that a highlighted background appears behind the toolbar icon.
Review checklist
Reminder for reviewers
Signed-off-by: seantan22 sean.a.tan@ericsson.com