Fix log on failure of command execution.#8978
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Jan 21, 2021
Merged
Fix log on failure of command execution.#8978colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
colin-grant-work
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Colin Grant colin.grant@ericsson.com
What it does
Fixes #8974 by removing the args from the log for the failed command execution.
How to test
It isn't easy to reproduce the bug, but it should be clear that this code can no longer fail due to problems with
JSON.stringify. See discussion on #8974 on the decision to simply remove the args.Review checklist
Reminder for reviewers