GH-7103: API for removing toolbar item.#9044
GH-7103: API for removing toolbar item.#9044paul-marechal merged 2 commits intoeclipse-theia:masterfrom
Conversation
Closes eclipse-theia#7103. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
A `TabBarToolbarContribution` cannot implement `registerToolbarItems` in an async way. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
westbury
left a comment
westbury
left a comment
There was a problem hiding this comment.
This looks good to me. In general, for removals, we need to ensure that contributions made by plugins can also be removed, which means keeping a list of removed items that is checked when plugins are installed. However I did not see anything in the plugin API that can add toolbar items so I think we are fine there.
I tested this by removing the ''scm.viewmode.list' item (contributed by the scm package) by calling unregisterItem from the git package.
The second commit to remove the unnecessary async looks good to me too.
This can be added later if the need comes up. |
3 participants
What it does
This PR adds API for removing toolbar contributions. Closes #7103.
How to test
Review checklist
Reminder for reviewers