9012-updating-userstorageuri-scheme

[danarad05]

scheme was changed from 'user_storage' to 'user-storage' as '_' is not a valid char in scheme (according to RFC 3986)

What it does

Fixes second problem in #9012 where JDTUtils threw exception when receiving file changed event whose URI scheme was user_storage -which is an illegal scheme name (contains underscore).
Therefore changed user_storage to user-storage scheme name.

For first problem in #9012 see #9048

How to test

1. Pre-requisite: 9012-registerTerminalLinkProvider-stub: for vscode-java-debug #9048 is merged
2. Open in Theia java project
3. After load you can run or debug project
   

Note:
for better behavior change this user setting to "internalConsole" (instead of "integratedTerminal"):
"java.debug.settings.console": "internalConsole".

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

It looks like the only way to address the problem. I've tested and confirmed that user storage is still being found correctly - preferences etc. are read and updated as expected. It looks like perhaps a sign-off is missing in the commit message (I believe that's why the Eclipse Foundation ECA check is failing), and the message itself is a bit long for a single line, but otherwise, this looks good. Hopefully there aren't too many explicit references to this URI in adopter code.

[danarad05]

It looks like the only way to address the problem. I've tested and confirmed that user storage is still being found correctly - preferences etc. are read and updated as expected. It looks like perhaps a sign-off is missing in the commit message (I believe that's why the Eclipse Foundation ECA check is failing), and the message itself is a bit long for a single line, but otherwise, this looks good. Hopefully there aren't too many explicit references to this URI in adopter code.

Thanks @colin-grant-work for review. Fixed signoff and long commit message.
Thanks

[amiramw]

I would like to merge this before the release if there is no objection