Generalized Output APIs.#9060
Merged
kittaakos merged 1 commit intoeclipse-theia:masterfrom Feb 23, 2021
Merged
Conversation
So that extenders can subclass and change the `scheme`. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
paul-marechal
approved these changes
Feb 18, 2021
Member
There was a problem hiding this comment.
LGTM, I am surprised as I would have assumed TS would under-specify automatically?
edit: TIL https://www.typescriptlang.org/docs/handbook/literal-types.html#literal-narrowing
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that extenders can subclass and change the
scheme.Signed-off-by: Akos Kitta kittaakos@typefox.io
What it does
Generalizes the Output APIs. The
schemeshould have a type ofstringinstead of'output'.Basically, I want to do something like this:
How to test
The code should compile.
Review checklist
Reminder for reviewers