Only execute file open command during drag-and-drop for dragged files#9093
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Feb 23, 2021
Merged
Conversation
Fix for DnD files to main area eclipse-theia#8739 Solves issue introduced in f840f60 Contributed by STMicroelectronics Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
vince-fugnitto
approved these changes
Feb 19, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the pull-request:
- fixes the error when attempting to dnd into the main-area not part of the nav
- the dnd of nav nodes still works correctly (single or multiple files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fix for DnD files to main area #8739
Solves issue introduced in f840f60
Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN samuel.hultgren@st.com
How to test
1, Select text in the "Problems" view, drag into the main area
2, Observe crash in the developer console without the patch:
Review checklist
Reminder for reviewers