Implement workspace.workspaceFile extension API#9132
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Mar 3, 2021
Merged
Implement workspace.workspaceFile extension API#9132vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
kittaakos
reviewed
Feb 26, 2021
kittaakos
reviewed
Feb 26, 2021
53c2127 to
8763593
Compare
This first implementation returns the Uri location of the workspace file even if it is untitled (i.e. saved on a temporary default location). Issue: eclipse-theia#8994 Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
8763593 to
ad42770
Compare
Contributor
Author
|
The recent commit adds a new event (onWorkspaceLocationChanged) in order to get notifications for the action "Save as" applied to a work space. |
vince-fugnitto
approved these changes
Mar 3, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I verified the changes and they work well 👍
I verified the following conditions:
| Use-Case | Result |
|---|---|
| No Workspace | The API correctly returns undefined |
| Non Multi-Root Workspace | The API correctly returns undefined |
| Unsaved Multi-Root Workspace | The API correctly returns the URI of the temporary workspace file location (untitled) |
| Saved Multi-Root Workspace | The API correctly returns the URI of the saved workspace file location |
Contributor
Author
|
Hi @kittaakos, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This first implementation returns the Uri location of the workspace
file even if it is untitled (i.e. saved on a temporary default
location).
Fixes: #8994
Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com
What it does
Introduces support for the plugin API: 'vscode.workspace.workspaceFile'
How to test
An test plugin that calls this API is available from: plugin
Once installed issue the command: "Test: Echo Workspace"
Review checklist
Reminder for reviewers