Skip to content

Fixed the fallback font-family in monaco editor.#9147

Merged
kittaakos merged 1 commit intoeclipse-theia:masterfrom
kittaakos:better-monaco-fallback-font
Mar 2, 2021
Merged

Fixed the fallback font-family in monaco editor.#9147
kittaakos merged 1 commit intoeclipse-theia:masterfrom
kittaakos:better-monaco-fallback-font

Conversation

@kittaakos
Copy link
Contributor

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

It fixes the fallback font-family in the monaco editor. Instead of falling back to the default UI font, which is

--theia-ui-font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

Screen Shot 2021-03-02 at 18 29 59

we fall back to the desired code editor font, which is

--theia-code-font-family: Menlo, Monaco, Consolas, "Droid Sans Mono", "Courier New", monospace, "Droid Sans Fallback";

Screen Shot 2021-03-02 at 18 31 01

How to test

  • Open the dev tools,
  • select a view-lines element,
  • and disable the default font-family.
    Screen Shot 2021-03-02 at 19 05 03

Review checklist

Reminder for reviewers

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@vince-fugnitto vince-fugnitto added monaco issues related to monaco ui/ux issues related to user interface / user experience labels Mar 2, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and make sense 👍

@kittaakos kittaakos merged commit 1110f99 into eclipse-theia:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

monaco issues related to monaco ui/ux issues related to user interface / user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants