preferences: restore preference state#9166
Merged
vince-fugnitto merged 1 commit intomasterfrom Mar 12, 2021
Merged
Conversation
The following commit restores the `preferences-ui` state when reloading the application. The state includes: - restoring the search term. - restoring the currently selected workspace scope. - restoring the editor location (through the `firstVisibleChildID`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
6d84f70 to
84bcaf1
Compare
Contributor
|
Code LGTM, and the functionality is as described. Thanks for picking up the slack left by the first Preference Widget commit 🙏 |
colin-grant-work
approved these changes
Mar 10, 2021
colin-grant-work
approved these changes
Mar 10, 2021
Member
Author
|
I'll merge the pull-request tomorrow if there are no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #7746
The following pull-request adds functionality in order to restore the
preferences-viewstate when reloading the application.The state includes:
firstVisibleChildID.Master:
master.mov
Pull-Request:
pr-search.mov
How to test
Search Term
fontSize)Scope
user,workspace,folder(multi-root))Editor
scss/lint)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com